-
-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/frontal solver #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e handling; remove unused variables and improve boundary condition application
…dling; streamline boundary condition application and remove debug logging
…r stiffness matrix assembly and improve code clarity
…ethods to use 'Front' suffix and streamline application in frontal solver
- Updated comments in `genericBoundaryConditionsScript.js`, `solidHeatTransferScript.js`, and `thermalBoundaryConditionsScript.js` to clarify the terminology used for residual and Jacobian matrices. - Renamed variables in `solidHeatTransferScript.js` and `thermalBoundaryConditionsScript.js` to use `localJacobianMatrix` and `residualVector` for clarity and consistency across the codebase. - Ensured that all references to stiffness/conductivity matrices and load vectors are aligned with the new naming conventions.
…al solver; update parameter names for clarity in thermal boundary conditions methods
…; update comments for clarity in frontal solver
…enhance clarity by removing redundant context
…on; enhance logic for better accuracy
…mprove clarity by differentiating logged data based on mesh dimension
…nology from "constant temperature" to "Dirichlet-type" and "convection" to "Robin-type"
…onditionsFront function
…eamline mapping logic for clarity and efficiency
…; enhance readability and maintainability
…nce flexibility for different solvers
…ripts; enhance clarity and consistency in boundary condition handling
….1.3 - Removed unused `logSystem` import from various example scripts. - Updated version number in `package-lock.json` and `index.js`. - Refactored `printVersion` function to `printVersionInformation` for clarity. - Added error logging for unsupported 1D front propagation in `frontPropagationScript.js`. - Cleaned up import statements for better readability in `FEAScript.js`.
…igation with a contents section
…tion and readability
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Frontal solver